The description doesn't match the styling. (There is no border 'around the page'.) Change 'boxes' to 'bars', and I would lose the margin-top and margin-bottom and just assert that the bar on the left is the same size as the bar on the right. Then the tester doesn't have to get out the ruler.
Melinda Grant, 2008/07/22 17:53
Also, might as well add assertion #59, since we're testing that here too. In general, we want to keep tests atomic; but it seems ok to me to bundle the page and mbox assertions on properties supported into one test. You may hear something else from others.
Tom Clancy, 2008/07/29 10:46
Done
Melinda Grant, 2008/08/06 12:10
My first set of comments doesn't seem to have been addressed. An oversight, or do you feel they require further discussion…?
Tom Clancy, 2008/08/07 10:03
No, just missed them. Should be all set now. Sorry.
Melinda Grant, 2008/08/12 18:35
Looks good.
You could leave a comment if you were logged in.
test/css2.1/submit/58.txt · Last modified: 2014/12/09 15:48 (external edit)
Discussion
The description doesn't match the styling. (There is no border 'around the page'.) Change 'boxes' to 'bars', and I would lose the margin-top and margin-bottom and just assert that the bar on the left is the same size as the bar on the right. Then the tester doesn't have to get out the ruler.
Also, might as well add assertion #59, since we're testing that here too. In general, we want to keep tests atomic; but it seems ok to me to bundle the page and mbox assertions on properties supported into one test. You may hear something else from others.
Done
My first set of comments doesn't seem to have been addressed. An oversight, or do you feel they require further discussion…?
No, just missed them. Should be all set now. Sorry.
Looks good.