This is an old revision of the document!
Requirements for a Test Review System
See also outline of a CSS test suite review system and Review Process Documentation.
Check off X tests and give them all the same comment
Find test by ID,
URL, title, etc.
Handle renaming of test
Track changes in same stream as comments (every subversion checkin adds a comment pointing to diff and new version)
Track status of test (needs review, needs work, etc)
Accept comments
Be test suite aware (which test belongs to which test suite); note that a test may belong to multiple test suites
Opt-in to hear comments on tests you reviewed (and accepted but second-level review found problems with?)
Easy to set up an account
Bulk submit preserving folder structure
Should work on all browsers
Workflow
Workflow for Test Author
Author identifies an assertion to test
Author designs and creates tests and, when possible, checks that the test behaves as expected in at least one implementation.
Author submits tests
Author gets back automated report of what's wrong
Author fixes tests to match format
Author resubmits tests, they pass
Author waits for review
Author receives review comments on 6/9 tests
Author fixes tests
Author resubmits tests
Author receives acknowledgement that tests have been accepted and checked in
Workflow for Reviewer
If the Reviewer has 'Owner' or 'Peer' status (see
review), the Reviewer searches the submittal data base for tests in the 'Accepted' state; if not, or if no 'Accepted' tests were found, Reviewer searches the submittal data base for tests in the 'Resubmitted' or 'Submitted' state and selects a test to review. (He or she cannot review his or her own tests.)
Reviewer looks for duplicate tests in the set of 'Approved', 'Accepted', and checked-in tests; if found, reject the lesser-quality test as 'Duplicate', or suggest merging the two tests.
Reviewer checks that the test assertion (whether explicit or implied) is justified by the specification.
Reviewer checks the test for correctness. (See the
CSS Test Review Checklist for details.) If no problems are found, set the status to 'Accepted'.
Otherwise, Reviewer enters comments explaining what changes need to be made and sets the status to 'NeedsWork'. (If the Reviewer has the Author's permission to make changes directly, the Reviewer may also change the test as necessary. In this case, the status is set to 'Resubmitted' and someone else, possibly the Author, must review.)
Workflow for Approver
Approver searches the submission database for tests in the 'Accepted' state.
Approver either accepts Reviewer's judgement and marks test as 'Approved'–or follows workflow as for Reviewer, above, except passing review results in 'Approved'.
Approver may suggest a new filename for checkin.
Workflow for CVS Monkey
If the test is now in the 'Approved' state, anyone with write access may now check it into the
W3C CSS Test database, renaming the file as appropriate, and setting the status to 'CheckedIn'.