Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revision Previous revision
Next revision
Previous revision
test:review-shepherd [2013/07/31 17:25]
rhauck added workflow diagram
test:review-shepherd [2014/12/09 15:48] (current)
Line 28: Line 28:
         - When the updated tests are submitted, another notification should be sent to the mailing list asking for review. ​         - When the updated tests are submitted, another notification should be sent to the mailing list asking for review. ​
         - A reviewer looks at the changes and decides if they satisfy the original review feedback. Likewise, ideally this is original reviewer, but may also be any other qualified person. ​         - A reviewer looks at the changes and decides if they satisfy the original review feedback. Likewise, ideally this is original reviewer, but may also be any other qualified person. ​
-  - Once the test/​changes has pass review, the reviewer should [[https://​github.com/​w3c/​testtwf-website/​blob/​gh-pages/​docs/​test-templates.md#​reviewer| note their acceptance in the test]] FIXME and re-submit the files to Mercurial. The commit message should ​indicating ​the test passed review and will be attached to the test in Shepherd. ​ The test status in Shepherd will then change to [[ http://​test.csswg.org/​shepherd/​search/​status/​accepted|Accepted]]+  - Once the test/​changes has pass review, the reviewer should [[https://​github.com/​w3c/​testtwf-website/​blob/​gh-pages/​docs/​test-templates.md#​reviewer| note their acceptance in the test]] FIXME and re-submit the files to Mercurial. The commit message should ​indicate ​the test passed review and will be attached to the test in Shepherd. ​ The test status in Shepherd will then change to [[ http://​test.csswg.org/​shepherd/​search/​status/​accepted|Accepted]]
   - The [[https://​test.csswg.org/​shepherd/​administration/​testsuite/​search/​status/​approved|Owner]] FIXME: //[This link should be exposed to all roles in Shepherd. Right now, only admins can see it]// of that suite can either approve the reviewer'​s judgement if the reviewer is known to be competent in this area, or review the test himself. Once the Owner is satisfied the test can be set to [[http://​test.csswg.org/​shepherd/​search/​status/​approved|Approved]] in Shepherd. (If the initial reviewer was an Owner then this step is automatic).   - The [[https://​test.csswg.org/​shepherd/​administration/​testsuite/​search/​status/​approved|Owner]] FIXME: //[This link should be exposed to all roles in Shepherd. Right now, only admins can see it]// of that suite can either approve the reviewer'​s judgement if the reviewer is known to be competent in this area, or review the test himself. Once the Owner is satisfied the test can be set to [[http://​test.csswg.org/​shepherd/​search/​status/​approved|Approved]] in Shepherd. (If the initial reviewer was an Owner then this step is automatic).
  
 
test/review-shepherd.txt · Last modified: 2014/12/09 15:48 (external edit)
Recent changes RSS feed Valid XHTML 1.0 Valid CSS Driven by DokuWiki